Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to have GPU available when DALI is just imported #1601

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Remove the need to have GPU available when DALI is just imported #1601

merged 1 commit into from
Jan 3, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Dec 21, 2019

  • makes the GPU allocators initialization fully lazy without any need to call to GPU unless it is used
  • issuing import nvidia.dali doesn't make any call to the GPU any longer
  • new DALI import test is added

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

  • It adds new feature needed because of DALI doesn't really use GPU when it is just imported so when import nvidia.dali is issues in python no call to GPU should be made

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    makes the GPU allocators initialization fully lazy without any need to call to GPU unless it is used
    issuing import nvidia.dali doesn't make any call to the GPU any longer
  • Affected modules and functionalities:
    AllocatorManager
  • Key points relevant for the review:
    Check how allocators are lazy initialized
  • Validation and testing:
    Current tests in CI. A new DALI import test is added. Local stress test.
  • Documentation (including examples):
    NA

JIRA TASK: [NA]

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043210]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043212]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043210]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043212]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043748]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043747]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043748]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1043747]: BUILD PASSED

- makes the GPU allocators initialization fully lazy without any need
  to call to GPU unless it is used
- issuing `import nvidia.dali` doesn't make any call to the GPU any longer
- new DALI import test is added

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1044234]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1044234]: BUILD PASSED

@JanuszL JanuszL merged commit 1c96cb6 into NVIDIA:master Jan 3, 2020
@JanuszL JanuszL deleted the remove_gpu_req branch January 3, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants