-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the need to have GPU available when DALI is just imported #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI MESSAGE: [1043210]: BUILD STARTED |
CI MESSAGE: [1043212]: BUILD STARTED |
CI MESSAGE: [1043210]: BUILD FAILED |
CI MESSAGE: [1043212]: BUILD FAILED |
CI MESSAGE: [1043748]: BUILD STARTED |
CI MESSAGE: [1043747]: BUILD STARTED |
CI MESSAGE: [1043748]: BUILD PASSED |
CI MESSAGE: [1043747]: BUILD PASSED |
- makes the GPU allocators initialization fully lazy without any need to call to GPU unless it is used - issuing `import nvidia.dali` doesn't make any call to the GPU any longer - new DALI import test is added Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
CI MESSAGE: [1044234]: BUILD STARTED |
CI MESSAGE: [1044234]: BUILD PASSED |
jantonguirao
approved these changes
Dec 23, 2019
klecki
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import nvidia.dali
doesn't make any call to the GPU any longerSigned-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
import nvidia.dali
is issues in python no call to GPU should be madeWhat happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
makes the GPU allocators initialization fully lazy without any need to call to GPU unless it is used
issuing
import nvidia.dali
doesn't make any call to the GPU any longerAllocatorManager
Check how allocators are lazy initialized
Current tests in CI. A new DALI import test is added. Local stress test.
NA
JIRA TASK: [NA]