Fix Transpose operator for batch size 1 as well as 1 channel images #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Transpose has a special code path for transposing data with one or more dimensions shapes equal 1 as cuTT doesn't handle this situation. However, this code path is wrong - Corrects the logic removing shapes equal to 1 and permutation connected to it. - Add logic to update the remaining permutation elements after removal of the one corresponding to shapes equal to 1 - Adds more test to permutation operator Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Closed
|
!build |
|
CI MESSAGE: [1054196]: BUILD STARTED |
|
CI MESSAGE: [1054196]: BUILD PASSED |
jantonguirao
approved these changes
Jan 2, 2020
| @@ -114,15 +114,16 @@ def check_transpose_layout(device, batch_size, shape, in_layout, permutation, | |||
|
|
|||
| def test_transpose_layout(): | |||
| batch_size = 3 | |||
There was a problem hiding this comment.
you can remove this line
klecki
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dimensions shapes equal 1 as cuTT doesn't handle this situation. However,
this code path is wrong
corresponding to shapes equal to 1
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Transpose has a special code path for transposing data with one or more dimensions shapes equal 1 as cuTT doesn't handle this situation. However, this code path is wrong
Corrects the logic removing shapes equal to 1 and permutation connected to it.
Add logic to update the remaining permutation elements after removal of the one corresponding to shapes equal to 1
Transpose operator
NA
Adds more test to permutation operator
No
JIRA TASK: [NA]