-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gluon iterator plugin #1683
Conversation
2ad2d10
to
5555ff8
Compare
dbf19c2
to
e9a9cee
Compare
!build |
CI MESSAGE: [1095917]: BUILD STARTED |
CI MESSAGE: [1095917]: BUILD FAILED |
!build |
CI MESSAGE: [1096498]: BUILD STARTED |
CI MESSAGE: [1096498]: BUILD FAILED |
Signed-off-by: Serge Panev <spanev@nvidia.com>
Signed-off-by: Serge Panev <spanev@nvidia.com>
Signed-off-by: Serge Panev <spanev@nvidia.com>
Signed-off-by: Serge Panev <spanev@nvidia.com>
!build |
CI MESSAGE: [1096675]: BUILD STARTED |
!build |
CI MESSAGE: [1100033]: BUILD STARTED |
CI MESSAGE: [1100033]: BUILD FAILED |
!build |
CI MESSAGE: [1110666]: BUILD STARTED |
CI MESSAGE: [1110666]: BUILD FAILED |
CI MESSAGE: [1110666]: BUILD PASSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to factor out some more code to the base class and make the docs a bit more understandable (and the preparation of the returned batch). Otherwise ok.
Signed-off-by: Serge Panev <spanev@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a typo left.
You can also slap a comment that mentions why or what we do to create returned batches
!build |
CI MESSAGE: [1119143]: BUILD STARTED |
CI MESSAGE: [1119143]: BUILD PASSED |
Signed-off-by: Serge Panev spanev@nvidia.com
Why we need this PR?
We need a simpler and more flexible iterator for the MXNet Gluon API, which doesn't require mxnet.io.DataBatch but only NDArrays. Also, we need the support of sparse batches (with non-uniform shape samples), that DataBatch doesn't allow.
This PR needs to be rebased on #1682
What happened in this PR?
Add a new MXNet-Gluon iterator.
The newly added iterator.
Iterator test added.