Fix two bugs:

[mzient]

1. Buffer linkage - in debug builds, the static fields require external linkage (and explicit instantiation).
2. Reshape - the tensors inside were reshaped, but the tensor list was not. Fixed now, using native TensorVector::Resize.

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Why we need this PR?

Pick one, remove the rest

• It fixes two bugs:

1. Buffer linkage - in debug builds, the static fields require external linkage (and explicit instantiation).
2. Reshape - the tensors inside were reshaped, but the tensor list was not. Fixed now, using native TensorVector::Resize.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

• What solution was applied:
  • Added explicit instantiation and out-of-class repetition of constexpr variable.
  • reshape.cc uses TensorVector::Reshap now
• Affected modules and functionalities:
  • reshape.cc
  • buffer.h, added buffer.cc
• Key points relevant for the review:
  ?
• Validation and testing:
  • Old tests apply
• Documentation (including examples):
  N/A

JIRA TASK: N/A

[mzient]

!build

[dali-automaton]

CI MESSAGE: [1108498]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [1108498]: BUILD PASSED

[szalpal]

Looks OK, although I don't like the fact, that growth_factor and shrink_thresh are not private and have accessors (get and set). I'd make them private or remove the accessors. If you don't mind running CI again, you could change it

[JanuszL]

Looks OK, although I don't like the fact, that growth_factor and shrink_thresh are not private and have accessors (get and set). I'd make them private or remove the accessors. If you don't mind running CI again, you could change it

But they are protected as any other important member of Buffer class.

[mzient]

Looks OK, although I don't like the fact, that growth_factor and shrink_thresh are not private and have accessors (get and set). I'd make them private or remove the accessors. If you don't mind running CI again, you could change it

Accessors are indispensable - they are used in Python backend and in library initialization. As for making them private - that would be inconsistent with the rest of the Buffer class, and I don't think it's worth to move members between visibility levels when it doesn't really change anything. Maybe when/if we decide to revisit tensorlist/vector again (which we should), it will be time to think about refactoring buffer, too.