Fix BBFlip issues #1738
Merged
Fix BBFlip issues #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
* Fix a bug in TensorList: copying from TensorVector on a wrong stream. * Rework ArgValue to remove allocation and free from steady-state execution path. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [1133736]: BUILD STARTED |
mzient
commented
Feb 17, 2020
| @@ -107,7 +107,7 @@ class DLL_PUBLIC TensorList : public Buffer<Backend> { | |||
| type.template Copy<SrcBackend, Backend>( | |||
| raw_mutable_tensor(i), | |||
| other[i].raw_data(), | |||
| other[i].size(), 0); | |||
| other[i].size(), stream); | |||
There was a problem hiding this comment.
This is the actual bug fix.
JanuszL
reviewed
Feb 17, 2020
JanuszL
reviewed
Feb 17, 2020
|
CI MESSAGE: [1133736]: BUILD PASSED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
!build |
|
CI MESSAGE: [1134649]: BUILD STARTED |
JanuszL
approved these changes
Feb 18, 2020
awolant
approved these changes
Feb 18, 2020
|
CI MESSAGE: [1134649]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
TensorList::CopyArgValuefor performance (removed allocations)TensorListArgValuehelper classBbFlip<GPUBackend>JIRA TASK: N/A