MelFilterBank GPU operator #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [1172983]: BUILD STARTED |
JanuszL
reviewed
Mar 6, 2020
Comment on lines
31
to
37
| using MelFilterBankKernel = kernels::audio::MelFilterBankGpu<T, Dims>; | ||
| kmgr_.Initialize<MelFilterBankKernel>(); | ||
| kmgr_.Resize<MelFilterBankKernel>(1, 1); | ||
| output_desc[0].type = TypeTable::GetTypeInfo(TypeTable::GetTypeID<T>()); | ||
| auto in_view = view<const T, Dims>(input); | ||
| auto &req = kmgr_.Setup<MelFilterBankKernel>(0, ctx_, in_view, args_); | ||
| output_desc[0].shape = req.output_shapes[0]; |
There was a problem hiding this comment.
Please, make indent aligned properly with the VALUE_SWITCH
JanuszL
approved these changes
Mar 6, 2020
Signed-off-by: Rafal <Banas.Rafal97@gmail.com>
banasraf
force-pushed
the
gpu-mel-filter-bank-operator
branch
from
bf7f80d
to
c528e61
Compare
jantonguirao
approved these changes
Mar 6, 2020
|
!build |
|
CI MESSAGE: [1173023]: BUILD STARTED |
|
CI MESSAGE: [1173023]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
What happened in this PR?
The operator just runs initializes and runs the kernel
MelFilterBank operator: new file + small changes in existing
SetupImpl and RunImpl
Existing MelFilterBank tests extended to gpu
The operator was already documented
JIRA TASK: DALI-1291