Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSDRandomCrop calculate crop window in double precision #1848

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 31, 2020

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a bug resulting in misalignment of crop window calculation between SSDRandomCrop and BBoxRandomCraop

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Made SSDRandomCrop calculate images in double precision
  • Affected modules and functionalities:
    SSDRandomCrop
  • Key points relevant for the review:
    NA
  • Validation and testing:
    run failing test case python test_detection_pipeline.py -s 2634774052 -i 300
  • Documentation (including examples):
    NA

JIRA TASK: [NA]

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 31, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1224160]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1224160]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1224275]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1224275]: BUILD PASSED

@mzient mzient changed the title Make SSDRandomCrop calculate images in double precision Make SSDRandomCrop calculate crop window in double precision Apr 1, 2020
@mzient mzient merged commit ca86fe6 into NVIDIA:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants