Numpy reader devel #1858
Merged
Numpy reader devel #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files before renaming
…osition for fortran ordered numpy arrays
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
JanuszL
reviewed
Apr 3, 2020
|
Some Jupyter example would be nice to show how it can be used. |
|
!build |
|
CI MESSAGE: [1239650]: BUILD STARTED |
jantonguirao
approved these changes
Apr 7, 2020
|
CI MESSAGE: [1239650]: BUILD PASSED |
JanuszL
reviewed
Apr 7, 2020
JanuszL
reviewed
Apr 7, 2020
JanuszL
reviewed
Apr 7, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
mzient
reviewed
Apr 8, 2020
JanuszL
approved these changes
Apr 8, 2020
|
!build |
|
CI MESSAGE: [1243203]: BUILD STARTED |
|
CI MESSAGE: [1243203]: BUILD FAILED |
JanuszL
reviewed
Apr 9, 2020
| // extract header length | ||
| uint16_t header_len = 0; | ||
| memcpy(&header_len, &token[8], 2); | ||
| DALI_ENFORCE(header_len % 16 == 0, |
…ength being integer multiples of 16, header-length+10 has to be modulo 16. Fixed
|
!build |
|
CI MESSAGE: [1244701]: BUILD STARTED |
|
CI MESSAGE: [1244701]: BUILD PASSED |
mzient
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
[ Added numpy_file_reader and -loader ]
[ dali/operators/reader ]
[ updated Dockerfile.deps with updated boost mirror, renaming of FIleLoader to FileLabelLoader (and the corresponding files, i.e. renamed file_loader. to file_label_loader.* and added file_loader.* with the new definition) in Dali/operators/reader/loader, numpy_loader.* and numpy_reader_op.* in the reader directory, inlined a few helper functions in dali/kernels/common/transpose.h, the header contained implementations which caused linking errors ]*
[ I ran the test suite for the existing operators and added a test for the numpy reader under dali/test/python. It basically creates a numpy file and loads it the regular way and also using the loader and compares the output]
[ No, nothing did change. I am happy to add a doc item for the reader though in case it is requested. ]
JIRA TASK: [ NA ]