DALI as a git submodule #1924
DALI as a git submodule #1924
Conversation
AlexBula
changed the title
CMakeLists.txt
Outdated
|
|
||
| export(PACKAGE dali) |
There was a problem hiding this comment.
I'd approach it a little bit differently: I think we should export individual targets within some namespace, e.g. using this:
export(TARGETS [target1 [target2 [...]]] [NAMESPACE <namespace>]
[APPEND] FILE <filename> [EXPORT_LINK_INTERFACE_LIBRARIES])
There you could export dali, dali_operators, dali_core etc....
Usage could be following:
add_subdirectory(extern/DALI)
target_link_libraries(mylib DALI::dali_core DALI::dali_kernels)
On top of that, we can expose convenient target that gathers every DALI target, so that user can go:
add_subdirectory(extern/DALI)
target_link_libraries(mylib DALI::DALI)
But I'd like to hear what others think about it
There was a problem hiding this comment.
you are probably right :)
There was a problem hiding this comment.
Changed so only the listed targets are exported
|
!build |
|
CI MESSAGE: [1291181]: BUILD STARTED |
|
CI MESSAGE: [1291181]: BUILD PASSED |
| add_library(DALI::dali ALIAS dali) | ||
| add_library(DALI::dali_core ALIAS dali_core) | ||
| add_library(DALI::dali_kernels ALIAS dali_kernels) | ||
| add_library(DALI::dali_operators ALIAS dali_operators) |
There was a problem hiding this comment.
Is it possible to additionally create one target, that puts together all these four?
One to rule them all ;)
There was a problem hiding this comment.
I do not think so, at least I did not find one
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Change CMakeLists paths to ${PROJECT_SOURCE_DIR}, add export of DALI
Few path in the CMakeLists were changed because they assumed DALI was the main project that was currently built
[ Describe here what is the most important part that reviewers should focus on. ]
Checked if DALI is building after changes
[ Describe here if documentation and examples were updated. ]
JIRA TASK: NA