Fix Slice pad support when last dimension is padded #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
commented
Jun 24, 2020
| /** | ||
| * @brief Fills output with nchannel values repeatedly | ||
| */ | ||
| template <typename T> |
There was a problem hiding this comment.
moved those to common utilities because they'll be reused (in a follow up PR)
jantonguirao
commented
Jun 24, 2020
| const OutputType *__restrict__ fill_values, int channel_dim, | ||
| uint64_t offset, uint64_t block_end) { | ||
| if (Dims > 1 && out_strides[Dims - 1] == in_strides[Dims - 1] && anchor[Dims - 1] == 0 && | ||
| if (Dims > 1 && anchor[Dims - 1] == 0 && in_shape[Dims - 1] == out_shape[Dims - 1] && |
There was a problem hiding this comment.
This is the core of the bug fix
|
!build |
|
CI MESSAGE: [1420323]: BUILD STARTED |
JanuszL
approved these changes
Jun 24, 2020
mzient
approved these changes
Jun 24, 2020
|
CI MESSAGE: [1420323]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
strides were used to fuse dimensions before. However, for the last dimension strides are the same so we ended up fusing a dimension that needed to be padded. To solve that, we switch to checking shapes instead of strides (out_shape had to be added)
Slice GPU kernel
Changes in the kernel
Unit tests added
N/A
JIRA TASK: [Use DALI-XXXX or NA]