Add better return value/error status checks #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [1426232]: BUILD STARTED |
jantonguirao
approved these changes
Jun 26, 2020
klecki
approved these changes
Jun 26, 2020
- adds TIFF decoder creation status - adds a couple of NVJPEG_CALL to ImageDecoder where nvJPEG library calls return values were not checked - adds rapidjson parsing status check - adds missing FFmpeg function return value checks - adds missing npp function return value checks Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1426232]: BUILD PASSED |
|
CI MESSAGE: [1426399]: BUILD STARTED |
|
CI MESSAGE: [1426399]: BUILD PASSED |
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Jun 29, 2020
- adds TIFF decoder creation status - adds a couple of NVJPEG_CALL to ImageDecoder where nvJPEG library calls return values were not checked - adds rapidjson parsing status check - adds missing FFmpeg function return value checks - adds missing npp function return value checks Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
added missing return value/error status checks when calling an external library
COCOreader
ImageDecoder GPU
VideoDecoder
TIFF decoder
If any unchecked value didn't slip out
CI
NA
JIRA TASK: [DALI-1180]