Fix layout propagation in Gaussian Blur #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1470181]: BUILD STARTED |
JanuszL
approved these changes
Jul 15, 2020
mzient
reviewed
Jul 15, 2020
| @@ -214,6 +214,7 @@ class GaussianBlurOpCpu : public OpImplBase<CPUBackend> { | |||
| void RunImpl(workspace_t<CPUBackend>& ws) override { | |||
| const auto& input = ws.template InputRef<CPUBackend>(0); | |||
| auto& output = ws.template OutputRef<CPUBackend>(0); | |||
| output.SetLayout(input.GetLayout()); | |||
There was a problem hiding this comment.
Suggested change
| output.SetLayout(input.GetLayout()); | |
| output.SetLayout(InputLayout(ws, 0)); |
This will keep the default layout from schema, if tensor has an empty one.
There was a problem hiding this comment.
Hmm, there are not default layouts in schema, and I can support anything with up to 3 data axes + 'F' and 'C' somewhere around it.
There was a problem hiding this comment.
I won't push it then for the sake of consistency/uniformity.
jantonguirao
approved these changes
Jul 15, 2020
mzient
approved these changes
Jul 15, 2020
|
CI MESSAGE: [1470181]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
What happened in this PR?
SetLayout added
Gaussian Blur
Nothing special
Added a test that based on Error:Assert on "ImageLayoutInfo::IsImage(input_layout_)" failed: Unsupported layout: '' for input 0 '__GaussianBlur_2' #2116 that was not working previously (output of GaussianBlur is consumed by operator checking the layout).
NA
JIRA TASK: [DALI-1507]