Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated use of ltrb in BboxRandomCrop #2141

Merged

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It removes usage of a deprecated argument in the documentation

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Updated the documentation to use bbox_layout="xyXY" instead of ltrb=True
  • Affected modules and functionalities:
    some jupyter docs
  • Key points relevant for the review:
    N/A
  • Validation and testing:
    N/A
  • Documentation (including examples):
    Changes are in documentation

JIRA TASK: [Use DALI-XXXX or NA]

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao requested a review from a team July 22, 2020 11:38
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1497866]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1497866]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1497866]: BUILD PASSED

@jantonguirao jantonguirao merged commit 3de17cd into NVIDIA:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants