Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when DALI runs on pre CUDA 11 driver using a compatibility layer #2208

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Aug 12, 2020

  • fixes crash caused by missing nvml symbol nvmlDeviceGetCpuAffinityWithinScope when DALI CUDA 11 build runs on pre 450.x driver with the compatibility layer enabled

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a failure when DALI runs on pre CUDA 11 driver using a compatibility layer

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    fixes crash caused by missing nvml symbol nvmlDeviceGetCpuAffinityWithinScope when DALI CUDA 11 build runs on pre 450.x driver with the compatibility layer enabled
  • Affected modules and functionalities:
    nvml wraper
  • Key points relevant for the review:
    if is_driver_sufficient is safe
  • Validation and testing:
    CI
  • Documentation (including examples):
    NA

JIRA TASK: [NA]

@JanuszL
Copy link
Contributor Author

JanuszL commented Aug 12, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539376]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539376]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539398]: BUILD STARTED

…y layer

- fixes crash caused by missing nvml symbol nvmlDeviceGetCpuAffinityWithinScope
  when DALI CUDA 11 build runs on pre 450.x driver with the compatibility layer
  enabled

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539420]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539418]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539398]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539420]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1539418]: BUILD PASSED

@JanuszL JanuszL merged commit ac04c55 into NVIDIA:master Aug 13, 2020
@JanuszL JanuszL deleted the fix_lack_of_nvml_compat branch August 13, 2020 20:45
klecki pushed a commit that referenced this pull request Sep 9, 2020
…y layer (#2208)

- fixes crash caused by missing nvml symbol nvmlDeviceGetCpuAffinityWithinScope
  when DALI CUDA 11 build runs on pre 450.x driver with the compatibility layer
  enabled

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants