Enhance error messages in case of not supported data types in operators #2211
Conversation
| ), DALI_FAIL(make_string("Unsupported output type: ", input.type().id()))) // NOLINT | ||
| ), DALI_FAIL(make_string("Unsupported input type: ", output_type_))) // NOLINT |
There was a problem hiding this comment.
The error messages are reversed wrt to the value shown.
dali/operators/generic/reshape.cc
Outdated
| @@ -223,7 +223,7 @@ void Reshape<Backend>::ShapeFromInput(const TensorListLike &tl, bool relative) { | |||
| (int8_t, uint8_t, int16_t, uint16_t, int32_t, uint32_t, int64_t, uint64_t), | |||
| (this->ShapeFromInput(view<const type>(tl));), | |||
| (DALI_FAIL(make_string(OpName(), ": shape input must have integral type; got: ", | |||
| tl.type().name(), " (id = ", static_cast<int>(tl.type().id()), ")"));) | |||
| tl.type().name(), " type: ", tl.type().id()));) | |||
There was a problem hiding this comment.
I think that typeid is readily converted to a string, so this would print the name twice.
| tl.type().name(), " type: ", tl.type().id()));) | |
| tl.type().id()));) |
I think these are distinct concepts. E.g. using a floating point number for an index is invalid, whereas resizing uint32_t image is unsupported. |
|
!build |
|
CI MESSAGE: [1573075]: BUILD STARTED |
|
CI MESSAGE: [1573075]: BUILD FAILED |
klecki
dismissed
their stale review
Some more changes needed: remove internal id from known types, differentiate better between no type set, invalid type and valid run-time registered type.
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
datatype_readable
branch
from
cb58abc
to
4a58ea9
Compare
|
!build |
|
CI MESSAGE: [1574232]: BUILD STARTED |
|
CI MESSAGE: [1574232]: BUILD FAILED |
|
CI MESSAGE: [1574232]: BUILD PASSED |
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Added DALIDataType string conversion
Adjusted every TYPE_SWITCH instance that was not printing the invalid type
Several ops
Changes in the way we handle type names
N/A
N/A
JIRA TASK: [Use DALI-XXXX or NA]