Fix VideoReader error checking when opening files #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error checking comparison was reversed on opening video files resulting in not reporting an error and further processing of corrupted file that ended in segfault. Now the error is caught and properly reported. Test was added. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1556117]: BUILD STARTED |
awolant
approved these changes
Aug 19, 2020
|
CI MESSAGE: [1556117]: BUILD FAILED |
|
CI MESSAGE: [1556117]: BUILD PASSED |
mzient
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error checking comparison was reversed on opening
video files resulting in not reporting an error
and further processing of corrupted file that
ended in segfault.
Now the error is caught and properly reported.
Test was added.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
It fixes a bug reported in #2221.
What happened in this PR?
Enforce check was reversed (errors have negative values).
VideoReader
Check if there are no more such mistakes. I went through the .cc file and it looks ok.
A corrupted file was added to DALI_extra. Test with that file was added.
N/A
JIRA TASK: [NA]