Fixes crash in RandomBBoxCrop when no labels are provided #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ProspectiveCrop assumed that labels are always provided and there the number is equal to the number of bboxes - extends logic to support has_labels variable Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
awolant
approved these changes
Sep 10, 2020
|
CI MESSAGE: [1614873]: BUILD STARTED |
jantonguirao
approved these changes
Sep 10, 2020
| @@ -333,3 +333,21 @@ def test_random_bbox_crop_overlap(): | |||
| for use_labels in [True, False]: | |||
| yield check_random_bbox_crop_overlap, \ | |||
| batch_size, ndim, crop_shape, input_shape, use_labels | |||
|
|
|||
| def test_random_bbox_crop_no_lables(): | |||
There was a problem hiding this comment.
Suggested change
| def test_random_bbox_crop_no_lables(): | |
| def test_random_bbox_crop_no_labels(): |
| return out | ||
| boxes = fn.external_source(source = get_boxes) | ||
| processed = fn.random_bbox_crop(boxes, | ||
| aspect_ratio=[0.5, 2.0], |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1614928]: BUILD STARTED |
|
CI MESSAGE: [1614873]: BUILD FAILED |
|
CI MESSAGE: [1614873]: BUILD PASSED |
|
CI MESSAGE: [1614928]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
extends logic to support has_labels variable in ProspectiveCrop
RandomBBoxCrop
NA
CI
test case has been added
Relates to #2262
JIRA TASK: [NA]