Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CUDA 11.1 builds #2302

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Enable CUDA 11.1 builds #2302

merged 5 commits into from
Oct 7, 2020

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 28, 2020

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It adds CUDA 11.1 based builds

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    adds CUDA 11.1 based builds
    uses CUDA 11.1 extended compatibility mode to build CUDA 11.0 DALI builds
  • Affected modules and functionalities:
    build process
    conda build process
    TF plugin build process
  • Key points relevant for the review:
    NA
  • Validation and testing:
    CI
  • Documentation (including examples):
    docs are updated

JIRA TASK: [NA]

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659870]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659871]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659875]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659876]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659875]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1659876]: BUILD FAILED

@JanuszL JanuszL force-pushed the cud111_build branch 2 times, most recently from c061aef to d0e2f79 Compare September 28, 2020 22:26
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661166]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661167]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661168]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661166]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661168]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661167]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661168]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661167]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1661166]: BUILD PASSED

@JanuszL JanuszL force-pushed the cud111_build branch 4 times, most recently from a709038 to 569a323 Compare October 5, 2020 09:58
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1676664]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1676684]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1676684]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1676684]: BUILD PASSED

@klecki klecki self-requested a review October 5, 2020 16:09
* for CUDA 11 and CUDA 11.1:

.. note::
CUDA 11.1 builds uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CUDA 11.1 builds uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x
CUDA 11.1 build uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.. note::
CUDA 11.1 builds uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x
toolkit while it can run on CUDA 11.0 capable drivers 450.80 or later. Using the newest driver may enable
additional functionalities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to link to some docs about extended compatibility. Googling that term brings nothing as of now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it when it is available

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
* for CUDA 11 and CUDA 11.1:

.. note::
CUDA 11.1 build uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CUDA 11.1 build uses CUDA toolkit extended compatibility. It is built with the latest CUDA 11.x
CUDA 11.1 build uses CUDA toolkit enhanced compatibility. It is built with the latest CUDA 11.x

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Oct 6, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1679663]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1679663]: BUILD FAILED


.. code-block:: bash

pip install --extra-index-url https://developer.download.nvidia.com/compute/redist/nightly nvidia-dali-nightly-cuda110 nvidia-dali-tf-plugin-nightly-cuda110
3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some random number left here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


.. code-block:: bash

pip install --extra-index-url https://developer.download.nvidia.com/compute/redist nvidia-dali-cuda110

pip install --extra-index-url https://developer.download.nvidia.com/compute/redist nvidia-dali-cuda111
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about splitting this to separate 11.0 and 11.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Oct 6, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1680208]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1680208]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1679663]: BUILD PASSED

@JanuszL JanuszL merged commit ebc8b56 into NVIDIA:master Oct 7, 2020
@JanuszL JanuszL deleted the cud111_build branch October 7, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants