Fix uniform generator operator #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [1695888]: BUILD STARTED |
|
CI MESSAGE: [1695888]: BUILD FAILED |
szalpal
reviewed
Oct 13, 2020
jantonguirao
approved these changes
Oct 13, 2020
|
If the range is [a,b] we should say so in the documentation. |
- for some reason uniform_real_distribution returns [a, b] instead of [a, b) so ask the generator to draw samples until they are < b - see http://open-std.org/JTC1/SC22/WG21/docs/lwg-active.html#2524 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_uniform_test
branch
from
98da885
to
96384b2
Compare
JanuszL
changed the title
|
!build |
szalpal
reviewed
Oct 13, 2020
dali/operators/random/uniform.cc
Outdated
Comment on lines
33
to
35
| while (sample_data[k] >= range_[1]) { | ||
| sample_data[k] = dist(rng_); | ||
| } |
There was a problem hiding this comment.
Suggested change
| while (sample_data[k] >= range_[1]) { | |
| sample_data[k] = dist(rng_); | |
| } | |
| do { | |
| sample_data[k] = dist(rng_); | |
| } while (sample_data[k] >= range_[1]); // Due to GCC and LLVM bug |
dali/operators/random/uniform.cc
Outdated
Comment on lines
22
to
27
| if (range_[0] >= range_[1]) { | ||
| for (int i = 0; i < batch_size_; ++i) { | ||
| sample_data[k] = range_[0]; | ||
| } | ||
| return; | ||
| } |
There was a problem hiding this comment.
I suggest adding argument verification in Uniform constructor, sth like:
if (discrete_mode_) {
set_ = spec.GetRepeatedArgument<float>("values");
DALI_ENFORCE(!set_.empty(), "`values` argument cannot be empty");
} else {
range_ = spec.GetRepeatedArgument<float>("range");
DALI_ENFORCE(range_.size() == 2, "`range` argument shall contain precisely 2 values");
DALI_ENFORCE(range_[0] < range_[1],
"Invalid range. It shall be left-closed [a, b), where a < b");
}
|
CI MESSAGE: [1696987]: BUILD STARTED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1697021]: BUILD STARTED |
mzient
reviewed
Oct 13, 2020
dali/operators/random/uniform.cc
Outdated
Comment on lines
22
to
27
| if (range_[0] >= range_[1]) { | ||
| for (int i = 0; i < batch_size_; ++i) { | ||
| sample_data[k] = range_[0]; | ||
| } | ||
| return; | ||
| } |
There was a problem hiding this comment.
It's no becessary if we enfornce that the range is not empty.
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1697032]: BUILD STARTED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1697074]: BUILD STARTED |
|
CI MESSAGE: [1697074]: BUILD FAILED |
szalpal
approved these changes
Oct 13, 2020
|
CI MESSAGE: [1697074]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
so ask the generator to draw samples until they are < b
uniform operator
NA
CI
NA
JIRA TASK: [NA]