Late initialization of torch_gpu_device in pytorch plugin #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your valuable contribution. |
|
Added test and dependency as you suggested. |
JanuszL
reviewed
Oct 28, 2020
|
One key think seems to be missing. Please fix it and I will put it through our CI. |
Co-authored-by: Janusz Lisiecki <39967756+JanuszL@users.noreply.github.com>
|
!build |
|
CI MESSAGE: [1741036]: BUILD STARTED |
klecki
approved these changes
Oct 28, 2020
JanuszL
approved these changes
Oct 28, 2020
|
CI MESSAGE: [1741036]: BUILD PASSED |
JanuszL
pushed a commit
that referenced
this pull request
Oct 28, 2020
* Late initialization of torch_gpu_device in pytorch plugin Authored-by: Marcin Chalecki <marcin.chalecki@tcl.com>
|
@mchalecki - thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to run pytorch plugin
DALIGenericIteratoron systems without gpu.Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Late initialization of torch_gpu_device variable, only when it is first needed.
Pytorch plugin
NA
NA
NA
JIRA TASK: [Use DALI-XXXX or NA]