Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geometric transform tutorial. #2530

Merged
merged 6 commits into from
Dec 18, 2020
Merged

Add geometric transform tutorial. #2530

merged 6 commits into from
Dec 18, 2020

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Dec 8, 2020

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

  • It adds new feature: tutorial for geometric transforms.

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • Added a jupyter notebook with a use case: transforming facial landmarks.
  • Affected modules and functionalities:
    • Docs.
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • N/A
  • Documentation (including examples):
    • 100% of the PR.

JIRA TASK: DALI-1762

@mzient mzient requested a review from a team December 8, 2020 17:10
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mzient mzient force-pushed the TransformTutorial branch 2 times, most recently from d18b9e2 to 7f2b276 Compare December 9, 2020 09:15
@review-notebook-app
Copy link

review-notebook-app bot commented Dec 10, 2020 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

awolant commented on 2020-12-10T07:46:16Z
----------------------------------------------------------------

In the docs review it was encouraged to use point style instead of First,

This would be something like: 1. Build a pipeline...

I just wanted to mention this here, but I don't have any preference.


JanuszL commented on 2020-12-18T08:32:53Z
----------------------------------------------------------------

👍

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 10, 2020 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

awolant commented on 2020-12-10T07:46:17Z
----------------------------------------------------------------

Combining Transforms as a section title is repeated. Maybe just remove the second one and make it one section?


JanuszL commented on 2020-12-18T08:32:41Z
----------------------------------------------------------------

👍

@mzient
Copy link
Contributor Author

mzient commented Dec 17, 2020

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1922387]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1922387]: BUILD PASSED

@mzient
Add geometric transform tutorial.
274e1cd 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Move transform docs to "math" directory.
aae567f 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Fix typo.
7f0a2d1 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient
Update dataset. Display images in 3 columns. Fix a bug in shear trans…
1e46c9c 
…form.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@JanuszL Review Notebook App
Copy link
Contributor

JanuszL commented Dec 18, 2020

👍

View entire conversation on ReviewNB

1 similar comment
@JanuszL Review Notebook App
Copy link
Contributor

JanuszL commented Dec 18, 2020

👍

View entire conversation on ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Dec 18, 2020 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

JanuszL commented on 2020-12-18T08:37:20Z
----------------------------------------------------------------

Why we need to slice and cat the shape in encoded_images_sizes? Maybe transpose would be more self-explanatory?


mzient commented on 2020-12-18T09:52:36Z
----------------------------------------------------------------

Transpose can't swap order.

@mzient Review Notebook App
Copy link
Contributor Author

mzient commented Dec 18, 2020

Transpose can't swap order.

View entire conversation on ReviewNB

@mzient
Allow 2x1 shear matrices. Remove duplicate section headers. Add tests…
09a93ad 
… for shear with run-time arguments.

Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1925750]: BUILD STARTED

@mzient
Fix seeds.
319b539 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1925750]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1926105]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [1926105]: BUILD PASSED

@mzient mzient merged commit 7702566 into NVIDIA:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awolant awolant awolant approved these changes

@JanuszL JanuszL JanuszL approved these changes

@jantonguirao jantonguirao jantonguirao approved these changes

Assignees

@jantonguirao jantonguirao

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzient @dali-automaton @JanuszL @jantonguirao @awolant