Hide ArithmeticGenericOp doc and disallow __bool__ #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
JanuszL
approved these changes
Dec 10, 2020
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
changed the title
|
!build |
|
CI MESSAGE: [1884565]: BUILD STARTED |
JanuszL
reviewed
Dec 10, 2020
|
|
||
| @raises(TypeError) | ||
| def test_bool_raises(): | ||
| bool(DataNode("dummy")) |
JanuszL
approved these changes
Dec 10, 2020
|
CI MESSAGE: [1884565]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [1893000]: BUILD STARTED |
|
CI MESSAGE: [1893000]: BUILD FAILED |
awolant
approved these changes
Dec 11, 2020
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1893802]: BUILD STARTED |
|
CI MESSAGE: [1893802]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [1901936]: BUILD STARTED |
|
CI MESSAGE: [1901936]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
Hides a doc of internal operator, prohibit using
__bool__on DataNodes.What happened in this PR?
ArithmeticGenericOp is no longer internal (it was already loaded) - this allows for loading it with regular functionality and properly handles hiding its docstring. MakeDocHidden() was added.
__bool__for DataNode was defined to always raise TypeError to prohibit mixing DataNodes with eager Python functions likemininstead of usingdali.math.min.SupportedOps doc, Arithm Ops
👀
👀
Tests for broken cases added.
yes
JIRA TASK: [Use DALI-XXXX or NA]