Time major Spectrogram (GPU-only) #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
!build |
mzient
commented
Jan 15, 2021
| args.spectrum_type = static_cast<FftSpectrumType>(power); | ||
| args.time_major_layout = layout == "tf"; |
There was a problem hiding this comment.
This line does the whole trick :)
JanuszL
reviewed
Jan 15, 2021
| @@ -27,59 +27,65 @@ | |||
| namespace dali { | |||
|
|
|||
| DALI_SCHEMA(Spectrogram) | |||
| .DocStr(R"code(Produces a spectrogram from a 1D signal (for example, audio). | |||
| .DocStr(R"(Produces a spectrogram from a 1D signal (for example, audio). | |||
There was a problem hiding this comment.
I would keep this code, it is consistent with the rest of the documentation.
JanuszL
approved these changes
Jan 15, 2021
|
if HW (HeightWidth) is row-major, why is ft frequency major? |
|
CI MESSAGE: [1985403]: BUILD STARTED |
The "major" coordinate is the outer one. Row-major is a matrix thing - it tells us that the outer coordinate indicates the row. |
|
CI MESSAGE: [1985403]: BUILD PASSED |
banasraf
approved these changes
Jan 18, 2021
TheTimmy
pushed a commit
to TheTimmy/DALI
that referenced
this pull request
Jan 20, 2021
* Add time-major GPU spectrogram. * Add tests for time-major spectrogram. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
"layout"argument with 2 values "tf" and "ft".JIRA TASK: N/A