Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert notebooks to fn API: audio_processing, custom_operator, serialization #2744

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

jantonguirao
Copy link
Contributor

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It converts several jupyter notebooks to use fn.* API instead of ops.*

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Converted notebooks to use functional API:./examples/advanced/serialization.ipynb, ./examples/audio_processing/audio_decoder.ipynb, ./examples/audio_processing/spectrogram.ipynb, ./examples/custom_operations/custom_operator/create_a_custom_operator.ipynb
  • Affected modules and functionalities:
    Documentation
  • Key points relevant for the review:
    NA
  • Validation and testing:
    NA
  • Documentation (including examples):
    NA

JIRA TASK: [DALI-1878]

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -370,14 +370,14 @@
"-- Detecting CXX compile features - done\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy operator objects in nvidia.dali.ops right?


Reply via ReviewNB

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2132444]: BUILD STARTED

…lization

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2132567]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2132567]: BUILD PASSED

@jantonguirao jantonguirao merged commit fb8d196 into NVIDIA:master Mar 4, 2021
@JanuszL JanuszL mentioned this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants