-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert notebooks to fn API: sequence_processing #2748
Conversation
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@@ -24,8 +24,8 @@ | |||
"import os.path\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what is the convention we want to follow, but I think that using absolute url to the docs (like https://docs.nvidia.com/deeplearning/dali/user-guide/docs/supported_ops.html#nvidia.dali.fn.readers.video
) will always land you in current release docs rather than the one you are looking at.
For example, clicking this in your local build takes you online. And going through this page for the docs for some old release and clicking it will take you to current one.
Same goes for other links added in this PR.
Reply via ReviewNB
View / edit / reply to this conversation on ReviewNB banasraf commented on 2021-03-03T17:32:27Z Finally, - comma |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
!build |
CI MESSAGE: [2132432]: BUILD STARTED |
CI MESSAGE: [2132432]: BUILD PASSED |
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Updated ./examples/sequence_processing/optical_flow_example.ipynb
Update ./examples/sequence_processing/sequence_reader_simple_example.ipynb
Updated ./examples/sequence_processing/video/video_file_list_outputs.ipynb
Updated ./examples/sequence_processing/video/video_reader_label_example.ipynb
Updated ./examples/sequence_processing/video/video_reader_simple_example.ipynb
Documentation
fn.* changes, links are correct.
NA
NA
JIRA TASK: [DALI-1881]