Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert notebooks to fn API: sequence_processing #2748

Merged
merged 8 commits into from
Mar 4, 2021

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Mar 2, 2021

Signed-off-by: Joaquin Anton janton@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It converts notebooks in docs/examples/sequence_processing to use fn.* API

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    Updated ./examples/sequence_processing/optical_flow_example.ipynb
    Update ./examples/sequence_processing/sequence_reader_simple_example.ipynb
    Updated ./examples/sequence_processing/video/video_file_list_outputs.ipynb
    Updated ./examples/sequence_processing/video/video_reader_label_example.ipynb
    Updated ./examples/sequence_processing/video/video_reader_simple_example.ipynb
  • Affected modules and functionalities:
    Documentation
  • Key points relevant for the review:
    fn.* changes, links are correct.
  • Validation and testing:
    NA
  • Documentation (including examples):
    NA

JIRA TASK: [DALI-1881]

Signed-off-by: Joaquin Anton <janton@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao jantonguirao changed the title [WIP] Convert notebooks to fn API: sequence_processing Convert notebooks to fn API: sequence_processing Mar 2, 2021
@banasraf banasraf self-assigned this Mar 3, 2021
@@ -24,8 +24,8 @@
"import os.path\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what is the convention we want to follow, but I think that using absolute url to the docs (like https://docs.nvidia.com/deeplearning/dali/user-guide/docs/supported_ops.html#nvidia.dali.fn.readers.video

) will always land you in current release docs rather than the one you are looking at.

For example, clicking this in your local build takes you online. And going through this page for the docs for some old release and clicking it will take you to current one.

Same goes for other links added in this PR.


Reply via ReviewNB

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

banasraf commented on 2021-03-03T17:32:27Z
----------------------------------------------------------------

Finally, - comma


Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2132432]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2132432]: BUILD PASSED

@jantonguirao jantonguirao merged commit d3b1859 into NVIDIA:master Mar 4, 2021
@JanuszL JanuszL mentioned this pull request May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants