Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optical flow parameter initialization. #2816

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Fix optical flow parameter initialization. #2816

merged 2 commits into from
Mar 25, 2021

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Mar 25, 2021 •
edited
Loading

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Why we need this PR?

Pick one, remove the rest

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    • default-initialize the param structure
    • provide disparityRange parameter
  • Affected modules and functionalities:
    • Optical flow
  • Key points relevant for the review:
    • N/A
  • Validation and testing:
    • Existing tests apply
  • Documentation (including examples):
    • N/A

JIRA TASK: DALI-1936

@mzient
Fix optical flow parameter initialization.
7f86add 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested a review from a team March 25, 2021 10:39
@mzient
Copy link
Contributor Author

mzient commented Mar 25, 2021

!build

@klecki klecki self-assigned this Mar 25, 2021
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2203464]: BUILD STARTED

JanuszL
JanuszL reviewed Mar 25, 2021
View reviewed changes
dali/operators/sequence/optical_flow/turing_of/optical_flow_turing.cc
@@ -152,6 +152,7 @@ void OpticalFlowTuring::CalcOpticalFlow(


void OpticalFlowTuring::SetInitParams(dali::optical_flow::OpticalFlowParams api_params) {
init_params_ = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to optical_flow_turing.h ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can put it also there, but I think that resetting the parameters here has its value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you.

@mzient
Initialize fields.
617754e 
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
@mzient mzient requested review from JanuszL and klecki March 25, 2021 10:59
@mzient
Copy link
Contributor Author

mzient commented Mar 25, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2203525]: BUILD STARTED

@JanuszL JanuszL mentioned this pull request Mar 25, 2021
Closed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2203525]: BUILD PASSED

@mzient mzient merged commit b26686b into NVIDIA:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanuszL JanuszL JanuszL approved these changes

@klecki klecki klecki approved these changes

Assignees

@klecki klecki

@JanuszL JanuszL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzient @dali-automaton @klecki @JanuszL