RNGBase to be used as base for noise augmentations + Add GaussianNoise operator (as an example) #2846
Conversation
jantonguirao
force-pushed
the
rng_base_with_input
branch
from
c6dcc28
to
8fc78d1
Compare
|
!build |
|
CI MESSAGE: [2260255]: BUILD STARTED |
|
CI MESSAGE: [2260255]: BUILD FAILED |
jantonguirao
force-pushed
the
rng_base_with_input
branch
from
8fc78d1
to
e4bfa14
Compare
|
!build |
|
CI MESSAGE: [2260507]: BUILD STARTED |
|
CI MESSAGE: [2260507]: BUILD PASSED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
rng_base_with_input
branch
from
e4bfa14
to
a0f7362
Compare
jantonguirao
changed the title
| template <typename T> | ||
| bool SetupDists(typename Dist<T>::type* dists_data, int nsamples) { | ||
| if (!mean_.IsDefined() && !stddev_.IsDefined()) { | ||
| return false; |
There was a problem hiding this comment.
What happens in that case?
There was a problem hiding this comment.
The default constructed Dist is used. This mechanism is mainly used for cases where we don't need to create a per sample instance and we are fine with the default constructed.
There was a problem hiding this comment.
Would the user know that not providing mean and stdev would make DALI to follow such code path?
Asking mostly from the user point of view.
dali/operators/random/rng_base_gpu.h
Outdated
| struct BlockDesc; | ||
|
|
||
| template <> | ||
| struct BlockDesc<false> { | ||
| int sample_idx; | ||
| void* start; |
There was a problem hiding this comment.
Why not output to be consistent with BlockDesc<true>?
There was a problem hiding this comment.
I can do that.
jantonguirao
changed the title
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [2266847]: BUILD STARTED |
|
CI MESSAGE: [2266847]: BUILD FAILED |
|
CI MESSAGE: [2266847]: BUILD PASSED |
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Introduced a
NeedsInputtemplate argument to RNGBase to support a family of noise augmentation operators.*Created a
fn.noise.gaussianas an example. The output ofnoise.gaussian(input, ...)is tested by comparing toinput + random.normal(...)*.random. operators*
Design of RNGBase
Python tests
NA
JIRA TASK: [DALI-1949] [DALI-1950]