Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates MXNet plugin documentation regarding last_batch_policy #2862

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Apr 13, 2021

  • in the case of MXNet both FILL and PARTIAL policies return a full batch
    every time, the only difference is a value of the pad property in the
    returned MXNet array. This PR adds proper documentation of that

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It updates MXNet plugin documentation regarding last_batch_policy

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    in the case of MXNet both FILL and PARTIAL policies return a full batch every time, the only difference is a value of the pad property in the returned MXNet array. This PR adds proper documentation of that
  • Affected modules and functionalities:
    mxnet.py
  • Key points relevant for the review:
    wording
  • Validation and testing:
    NA
  • Documentation (including examples):
    Only docs are updated

JIRA TASK: [NA]

- in the case of MXNet both `FILL` and `PARTIAL` policies return a full batch
  every time, the only difference is a value of the `pad` property in the
  returned MXNet array. This PR adds proper documentation of that

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 13, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2265378]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2265378]: BUILD PASSED

@JanuszL JanuszL merged commit d68c810 into NVIDIA:master Apr 16, 2021
@JanuszL JanuszL deleted the update_mxnet_plugin_docs branch April 16, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants