Fix failing test for Numba Func #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2021 10:16
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
jantonguirao
approved these changes
Apr 22, 2021
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
|
!build |
|
CI MESSAGE: [2294233]: BUILD STARTED |
|
CI MESSAGE: [2294233]: BUILD PASSED |
JanuszL
reviewed
Apr 22, 2021
JanuszL
reviewed
Apr 22, 2021
| def test_multiple_ins(): | ||
| pipe = numba_multiple_ins_pipe(shapes=(10, 10), dtype=np.uint8, batch_size=8, num_threads=1, device_id=0, run_fn=multiple_ins_run, setup_fn=multiple_ins_setup, | ||
| pipe = numba_multiple_ins_pipe(shapes=[(10, 10)], dtype=np.uint8, batch_size=8, num_threads=1, device_id=0, run_fn=multiple_ins_run, setup_fn=multiple_ins_setup, |
There was a problem hiding this comment.
Yes, that fixes test. I populated data in wrong way. That's why I added additional checks basing on what data type user pass and what user expect.
Fix for dead ptr is adding out_shapes_ member variable and holding pointers to it.
Signed-off-by: Rafal Maj <rmaj@nvidia.com>
JanuszL
approved these changes
Apr 22, 2021
|
!build |
|
CI MESSAGE: [2294485]: BUILD STARTED |
jantonguirao
approved these changes
Apr 22, 2021
|
CI MESSAGE: [2294485]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why we need this PR?
What happened in this PR?
[ Passed correct data to test and add checks if data passed by user is in same shape that user expects ]
[ Additional checks in numba_func.cc ]
[ NA ]
[ NA ]
[ NA ]