Improve Tensors docs #2915
Merged
Improve Tensors docs #2915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Expose the CUDA and NumPy Array Interface * Add links to the above * Add a paragraph about the memory being wrapped * Mention that the memory is invalidated in subsequent iteration * Add better cross-links * Turn on plugin for section labels (easy links in one .rst) Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2322569]: BUILD STARTED |
|
CI MESSAGE: [2322569]: BUILD FAILED |
JanuszL
approved these changes
Apr 30, 2021
mzient
reviewed
May 5, 2021
dali/python/backend_impl.cc
Outdated
| )code"); | ||
| tensor_cpu_binding.doc() = R"code( | ||
| Class representing a Tensor with memory residing on CPU. It can be used to access individual |
There was a problem hiding this comment.
Suggested change
| Class representing a Tensor with memory residing on CPU. It can be used to access individual | |
| Class representing a Tensor residing in host memory. It can be used to access individual |
mzient
reviewed
May 5, 2021
dali/python/backend_impl.cc
Outdated
| )code"); | ||
| tensor_gpu_binding.doc() = R"code( | ||
| Class representing a Tensor with memory residing on GPU. It can be used to access individual |
There was a problem hiding this comment.
Suggested change
| Class representing a Tensor with memory residing on GPU. It can be used to access individual | |
| Class representing a Tensor residing in GPU memory. It can be used to access individual |
banasraf
approved these changes
May 10, 2021
Needed when the docs is built without DALI source repo, as only installed DALI is needed for it. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [2352616]: BUILD STARTED |
|
CI MESSAGE: [2352616]: BUILD PASSED |
JanuszL
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com
Why we need this PR?
What happened in this PR?
What solution was applied:
Affected modules and functionalities:
Types -> Tensor docs mostly
Key points relevant for the review:
If what I wrote is true.
Validation and testing:
Read the docs, please.
Documentation (including examples):
Yes, indeed.
JIRA TASK: [Use DALI-XXXX or NA]