Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing av_bsf_flush call to the VideoReader seek function #2916

Merged
merged 1 commit into from
May 5, 2021

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Apr 30, 2021

  • when mpeg4_unpack_bframe is used the filter handle stores information
    about packed B frames. When we seek in a stream or change streams
    between files this can confuse the filter and cause it to drop B-Frames

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a missing av_bsf_flush call to a VideoRader seek function

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    when mpeg4_unpack_bframe is used the filter handle stores information about packed B frames. When we seek in a stream or change streams between files this can confuse the filter and cause it to drop B-Frames
  • Affected modules and functionalities:
    video_loader.cc
  • Key points relevant for the review:
    NA
  • Validation and testing:
    CI
  • Documentation (including examples):
    NA

Related to #2905 and #2818
JIRA TASK: [NA]

@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 30, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2324132]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2324132]: BUILD FAILED

- when mpeg4_unpack_bframe is used the filter handle stores information
  about packed B frames. When we seek in a stream or change streams
  between files this can confuse the filter and cause it to drop B-Frames

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@jantonguirao jantonguirao changed the title Add a missing av_bsf_flush call to a VideoRader seek function Add a missing av_bsf_flush call to a VideoReader seek function May 5, 2021
@jantonguirao jantonguirao changed the title Add a missing av_bsf_flush call to a VideoReader seek function Add a missing av_bsf_flush call to the VideoReader seek function May 5, 2021
@JanuszL
Copy link
Contributor Author

JanuszL commented May 5, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2337127]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2337127]: BUILD PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants