RNGBase: Separate noise generation and application steps #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
rng_base_rework
branch
2 times, most recently
from
f462569
to
771f972
Compare
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
rng_base_rework
branch
from
771f972
to
11e8c74
Compare
JanuszL
reviewed
May 7, 2021
dali/operators/random/coin_flip.h
Outdated
|
|
||
| namespace dali { | ||
|
|
||
| template <typename Backend, typename T> |
JanuszL
reviewed
May 7, 2021
JanuszL
reviewed
May 7, 2021
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
reviewed
May 7, 2021
JanuszL
reviewed
May 7, 2021
Signed-off-by: Joaquin Anton <janton@nvidia.com>
mzient
reviewed
May 7, 2021
Comment on lines
56
to
57
| template <typename T, typename Dist, bool IsNoiseGen, bool DefaultDist> | ||
| __global__ void RNGKernel(BlockDesc<IsNoiseGen>* __restrict__ block_descs, |
There was a problem hiding this comment.
Suggested change
| template <typename T, typename Dist, bool IsNoiseGen, bool DefaultDist> | |
| __global__ void RNGKernel(BlockDesc<IsNoiseGen>* __restrict__ block_descs, | |
| template <typename T, typename Dist, bool DefaultDist, bool IsNoiseGen,> | |
| __global__ void RNGKernel(BlockDesc<IsNoiseGen>* __restrict__ block_descs, |
Nitpick: This way you won't have to pass IsNoiseGen explicitly - it will be inferred from block_descs.
JanuszL
approved these changes
May 7, 2021
Signed-off-by: Joaquin Anton <janton@nvidia.com>
mzient
approved these changes
May 10, 2021
|
!build |
|
CI MESSAGE: [2353184]: BUILD STARTED |
|
CI MESSAGE: [2353184]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Created Impl for all RNGBase based classes, with Generate(...) and Apply(...) methods (Apply only applicable for noise generators)
Dropped float16 support for the sake of better maintainability
RNG and Noise generators
All
Existing tests apply
NA
JIRA TASK: [DALI-2010]