NumpyReader to use HostWorkspace #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [2432291]: BUILD STARTED |
JanuszL
reviewed
Jun 2, 2021
| int ndim = file_0.image.shape().sample_dim(); | ||
|
|
||
| TensorListShape<> sh(max_batch_size_, ndim); | ||
| for (int i = 0; i < max_batch_size_; i++) { |
There was a problem hiding this comment.
Maybe instead of max_batch_size_ it should check size of prefetched_batch_queue_[curr_batch_consumer_]. Just for the future.
JanuszL
approved these changes
Jun 2, 2021
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
reviewed
Jun 2, 2021
| @@ -118,12 +118,12 @@ bool NumpyReader::SetupImpl(std::vector<OutputDesc> &output_desc, | |||
| // If necessary start prefetching thread and wait for a consumable batch | |||
| DataReader<CPUBackend, ImageFileWrapper>::SetupImpl(output_desc, ws); | |||
|
|
|||
| int batch_size = prefetched_batch_queue_[curr_batch_consumer_].size(); | |||
There was a problem hiding this comment.
How about making that a function, like GetCurrentBatchSize() or something?
JanuszL
approved these changes
Jun 2, 2021
|
CI MESSAGE: [2432291]: BUILD FAILED |
awolant
approved these changes
Jun 4, 2021
|
!build |
|
CI MESSAGE: [2440607]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
numpy_reader_host_ws
branch
from
842f2d9
to
449d4f1
Compare
|
!build |
|
CI MESSAGE: [2441014]: BUILD STARTED |
|
CI MESSAGE: [2441014]: BUILD FAILED |
|
CI MESSAGE: [2441014]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Why we need this PR?
Pick one, remove the rest
What happened in this PR?
Fill relevant points, put NA otherwise. Replace anything inside []
Reworked NumpyReader to use HostWorkspace instead of SampleWorkspace, so that we can control the level of parallelism (e.g. intra-sample parallelism)
NumpyReader
NA
Existing tests apply
NA
JIRA TASK: [DALI-2127]