Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Video reader documentation #3035

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Jun 10, 2021

  • fixes typo in the filenames argument description
  • improves error message when timestamps and/or frame numbers
    are requested as an output but no labels are provided
  • fix typo in buffer typo mismatch error

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Why we need this PR?

Pick one, remove the rest

  • It fixes a Video reader documentation

What happened in this PR?

Fill relevant points, put NA otherwise. Replace anything inside []

  • What solution was applied:
    fixes typo in the filenames argument description
    improves error message when timestamps and/or frame numbers are requested as an output but no labels are provided
    fix typo in buffer typo mismatch error
  • Affected modules and functionalities:
    video reader
    buffer.h
  • Key points relevant for the review:
    NA
  • Validation and testing:
    CI
  • Documentation (including examples):
    only documentation and error messages are updated

JIRA TASK: [NA]

- fixes typo in the `filenames` argument description
- improves error message when timestamps and/or frame numbers
  are requested as an output but no labels are provided
- fix typo in buffer typo mismatch error

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Jun 10, 2021

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2460503]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [2460503]: BUILD PASSED

@JanuszL JanuszL merged commit 1eac991 into NVIDIA:main Jun 11, 2021
@JanuszL JanuszL deleted the fix_documetnation branch June 11, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants