Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad operator: Add support for per-sample axes and fill_value arguments, and negative axes #3534

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Pad operator: Add support for per-sample axes and fill_value arguments, and negative axes #3534

merged 2 commits into from
Dec 1, 2021

Conversation

jantonguirao
Copy link
Contributor

@jantonguirao jantonguirao commented Nov 25, 2021 •
edited
Loading

Signed-off-by: Joaquin Anton janton@nvidia.com

Description

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (Redesign of existing code that doesn't affect functionality)
  • Other (e.g. Documentation, Tests, Configuration)

What happened in this PR

Enhanced Pad operator to support the following:

  • Per-sample axes
  • Per-sample fill_value
  • Negative axes [-ndim, ndim-1] (negative values are counted from the back)

This PR also extracts some test utilities to be reused both in Slice and Pad tests, to avoid repetition

Additional information

  • Affected modules and functionalities:

Pad operator

  • Key points relevant for the review:

Changes in pad operator

Checklist

Tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements (requirement updated)
  • N/A

REQ IDs: PAD.06

JIRA TASK: DALI-2479

jantonguirao
jantonguirao commented Nov 25, 2021
View reviewed changes
dali/operators/util/axis_args.cc
if (shape_.num_elements() == 0) {
shape_ = uniform_list_shape(nsamples, sh);
} else {
for (int i = 0; i < shape_.size(); i++) {
Copy link
Contributor Author

@jantonguirao jantonguirao Nov 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before empty samples were not properly supported (only empty constant).
Note: New tests added to slice to cover that as well

@jantonguirao jantonguirao changed the title Add support for per-sample and negative axes to Pad operator Pad operator: Add support for per-sample axes and fill_value arguments, and negative axes Nov 25, 2021
@jantonguirao jantonguirao marked this pull request as ready for review November 25, 2021 19:33
@jantonguirao
Add support for per-sample and negative axes to Pad operator
9456d06 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@mzient mzient self-assigned this Nov 26, 2021
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3493009]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3493009]: BUILD FAILED

@jantonguirao
Bugfix
482ccac 
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3499027]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3499027]: BUILD FAILED

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3499948]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3499948]: BUILD FAILED

@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3501892]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3501892]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [3501892]: BUILD PASSED

@jantonguirao jantonguirao merged commit 3c217a9 into NVIDIA:main Dec 1, 2021
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
5e46264 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
db40cf4 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
b678e48 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
e2afc96 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
d83d77e 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
0dc001b 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
53b7daa 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
4f43d29 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
6a64ba3 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
0f2bea3 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
ae3c1e4 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
a23186f 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jan 23, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
40746ff 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Feb 21, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
2a1d897 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request May 13, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
a64c981 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
cyyever pushed a commit to cyyever/DALI that referenced this pull request Jun 7, 2022
@jantonguirao @cyyever
Pad operator: Add support for per-sample axes and fill_value argument…
6fa1277 
…s, and negative axes (NVIDIA#3534)

Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzient mzient mzient approved these changes

@awolant awolant awolant approved these changes

Assignees

@mzient mzient

@awolant awolant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jantonguirao @dali-automaton @mzient @awolant