Fix scalar handling in GPU cast

[mzient]

Signed-off-by: Michał Zientkiewicz mzient@gmail.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

Scalars were not properly handled in operator cast - there was an attempt to collapse the shape, which failed catastrophically (assertion in Debug build and access violation in Release) if the input shape is 0D, in which case it needs to be artificially expanded.
This PR adds special handling for that case.

Additional information:

Affected modules and functionalities:

Operator cast.

Key points relevant for the review:

N/A

TODO (separate PR): Add proper tests for operator cast.

Checklist

Tests

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[mzient]

!build

[dali-automaton]

CI MESSAGE: [4899734]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [4899734]: BUILD PASSED

[stiepan]

I get that adding thorough testing may be out of scope, but how about including here a single test case that would explode without the fix and passes otherwise?

[mzient]

I get that adding thorough testing may be out of scope, but how about including here a single test case that would explode without the fix and passes otherwise?

I don't think it's worth wasting a perfectly good CI run ;)

[jantonguirao]

I get that adding thorough testing may be out of scope, but how about including here a single test case that would explode without the fix and passes otherwise?

I agree that such test is a good idea.