Frames decoder gpu without index #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
!build |
|
CI MESSAGE: [6054940]: BUILD STARTED |
JanuszL
reviewed
Sep 30, 2022
Comment on lines
39
to
43
| if (frames_decoder->HasIndex()) { | ||
| return frames_decoder->ProcessPictureDecodeWithIndex(user_data, picture_params); | ||
| } | ||
|
|
||
| return frames_decoder->ProcessPictureDecodeWithoutIndex(user_data, picture_params); |
There was a problem hiding this comment.
In this case I think that if/else is more verbose about one of the options, as it is not early exit after all.
Suggested change
| if (frames_decoder->HasIndex()) { | |
| return frames_decoder->ProcessPictureDecodeWithIndex(user_data, picture_params); | |
| } | |
| return frames_decoder->ProcessPictureDecodeWithoutIndex(user_data, picture_params); | |
| if (frames_decoder->HasIndex()) { | |
| return frames_decoder->ProcessPictureDecodeWithIndex(user_data, picture_params); | |
| } else { | |
| return frames_decoder->ProcessPictureDecodeWithoutIndex(user_data, picture_params); | |
| } |
|
CI MESSAGE: [6054940]: BUILD PASSED |
awolant
changed the title
mzient
reviewed
Oct 6, 2022
Comment on lines
366
to
370
| if (HasIndex()) { | ||
| return ReadNextFrameWithIndex(data, copy_to_output); | ||
| } | ||
|
|
||
| return ReadNextFrameWithoutIndex(data, copy_to_output); |
There was a problem hiding this comment.
Nitpick - for symmetry
Suggested change
| if (HasIndex()) { | |
| return ReadNextFrameWithIndex(data, copy_to_output); | |
| } | |
| return ReadNextFrameWithoutIndex(data, copy_to_output); | |
| if (HasIndex()) { | |
| return ReadNextFrameWithIndex(data, copy_to_output); | |
| } else { | |
| return ReadNextFrameWithoutIndex(data, copy_to_output); | |
| } |
mzient
reviewed
Oct 6, 2022
| } | ||
|
|
||
| bool FramesDecoderGpu::EmptyBuffer() const { | ||
| for (auto &frame_ : frame_buffer_) { |
There was a problem hiding this comment.
Suggested change
| for (auto &frame_ : frame_buffer_) { | |
| for (auto &frame : frame_buffer_) { |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6116405]: BUILD STARTED |
mzient
reviewed
Oct 7, 2022
| * @note This constructor assumes that the `memory_file` and | ||
| * `memory_file_size` arguments cover the entire video file, including the header. | ||
| */ | ||
| FramesDecoder(const char *memory_file, int memory_file_size, bool build_index = true); | ||
|
|
||
| /** | ||
| * @brief Number of frames in the video. It returns 0, if this information is unavailable. | ||
| * | ||
| * |
There was a problem hiding this comment.
When you touch these lines - they should just go away if we don't have anything after "brief".
There was a problem hiding this comment.
The IDE trimmed the trailing whitespaces. Nevertheless, removed.
|
CI MESSAGE: [6116405]: BUILD PASSED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
reviewed
Oct 10, 2022
stiepan
reviewed
Oct 10, 2022
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
stiepan
approved these changes
Oct 11, 2022
mzient
reviewed
Oct 12, 2022
| @@ -108,11 +114,21 @@ class DLL_PUBLIC FramesDecoderGpu : public FramesDecoder { | |||
|
|
|||
| BufferedFrame& FindEmptySlot(); | |||
|
|
|||
| bool HasEmptySlot() const; | |||
|
|
|||
| bool EmptyBuffer() const; | |||
There was a problem hiding this comment.
Reads like "empty the buffer" == "make it empty".
Suggested change
| bool EmptyBuffer() const; | |
| bool BufferEmpty() const; |
or
Suggested change
| bool EmptyBuffer() const; | |
| bool IsBufferEmpty() const; |
mzient
reviewed
Oct 12, 2022
| return false; | ||
| } | ||
|
|
||
| bool FramesDecoderGpu::EmptyBuffer() const { |
There was a problem hiding this comment.
Suggested change
| bool FramesDecoderGpu::EmptyBuffer() const { | |
| bool FramesDecoderGpu::BufferEmpty() const { |
or
Suggested change
| bool FramesDecoderGpu::EmptyBuffer() const { | |
| bool FramesDecoderGpu::IsBufferEmpty() const { |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
mzient
approved these changes
Oct 12, 2022
|
CI MESSAGE: [6161684]: BUILD STARTED |
|
CI MESSAGE: [6161733]: BUILD STARTED |
|
CI MESSAGE: [6161684]: BUILD PASSED |
|
CI MESSAGE: [6161733]: BUILD FAILED |
|
CI MESSAGE: [6167376]: BUILD STARTED |
|
CI MESSAGE: [6167376]: BUILD PASSED |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building the internal index
Category:
New feature (non-breaking change which adds functionality)
Description:
building the internal index
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3038