Adds a cuda stream synchronization before cuvidUnmapVideoFrame in nvDecoder #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecoder - adds a GPU synchronization point before cuvidUnmapVideoFrame in nvDecoder similarly to the VideoSdk examples Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6436020]: BUILD STARTED |
|
CI MESSAGE: [6436020]: BUILD PASSED |
szalpal
approved these changes
Nov 9, 2022
mzient
reviewed
Nov 9, 2022
| @@ -427,6 +427,8 @@ void NvDecoder::receive_frames(SequenceWrapper& sequence) { | |||
| nv_time_base_)); | |||
| if (stop_) break; | |||
| convert_frame(frame, sequence, i); | |||
| // synchronize before MappedFrame is destroyed and cuvidUnmapVideoFrame is called | |||
| cudaStreamSynchronize(stream_); | |||
There was a problem hiding this comment.
Suggested change
| cudaStreamSynchronize(stream_); | |
| CUDA_CALL(cudaStreamSynchronize(stream_)); |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6444620]: BUILD STARTED |
|
CI MESSAGE: [6444620]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Nov 14, 2022
…ecoder (#4426) - adds a GPU synchronization point before cuvidUnmapVideoFrame in nvDecoder similarly to the VideoSdk examples Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similarly to the VideoSdk examples
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
similarly to the VideoSdk examples
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A