Add release_unused function to memory pools.
#4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [6967204]: BUILD STARTED |
JanuszL
approved these changes
Jan 9, 2023
|
CI MESSAGE: [6967204]: BUILD PASSED |
szalpal
approved these changes
Jan 10, 2023
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
Add release_unused function to memory pools. The function frees memory that's not currently in use and can be safely freed. * Generic pool: release only complete blocks allocated from the upstream * CUDA VM resource: release all blocks that are fully available * Async pool - collect per-stream free blocks first, then release_upstream on the global pool. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com
Category:
New feature (non-breaking change which adds functionality)
Description:
As per user-request, this adds the functionality necessary to implement memory "garbage collection".
Internally, there are three implementations:
release_unusedon it.free_mapped. The virtual address space is not a concern and is never freed.The relevant changes in public APIs are not in the scope of this PR - it just implements the underlying functionality
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Existing pool tests were extended by inserting a call to
release_unusedhalfway through the test.cuda_vm_resourcereceived a new test, since this functionality is otherwise not tested, whereas other a regular pool may userelease_unused_implto reclaim memory before allocating a new block from upstream..Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3170