Do not use numpy.typing when not available #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
JanuszL
approved these changes
Mar 13, 2023
|
CI MESSAGE: [7566667]: BUILD STARTED |
|
CI MESSAGE: [7566667]: BUILD FAILED |
mzient
approved these changes
Mar 13, 2023
|
CI MESSAGE: [7566667]: BUILD PASSED |
18 tasks
stiepan
added a commit
that referenced
this pull request
Mar 14, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
aderylo
pushed a commit
to zpp-dali-2022/DALI
that referenced
this pull request
Mar 17, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
For Python3.6 the 1.20 and newer versions of numpy are not available, which means numpy.typing won't work there.
This PR adds a fallback for when the numpy.typing is not avialable.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A