Fix missing source info in the numpy reader output #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [7594045]: BUILD STARTED |
|
CI MESSAGE: [7594045]: BUILD FAILED |
|
CI MESSAGE: [7594045]: BUILD PASSED |
klecki
approved these changes
Mar 16, 2023
mzient
reviewed
Mar 22, 2023
| @@ -658,13 +669,10 @@ def check_pad_last_sample(device): | |||
| for _ in range(2): | |||
| pipe_out = pipe.run() | |||
| for i in range(batch_size): | |||
| pipe_arr = to_array(pipe_out[0][i]) | |||
| out_arr = to_array(pipe_out[0][i]) | |||
| out_prop = to_array(pipe_out[1][i]) | |||
There was a problem hiding this comment.
SourceInfo has a first-class support, so you could just do:
Suggested change
| out_prop = to_array(pipe_out[1][i]) | |
| out_prop = pipe_out[0][i].source_info() |
This way there wouldn't be a need to use get_property() in the pipeline.
- fixes missing copy of the source info metadata from samples read in the numpy reader (CPU and GPU) to the operator output Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
fix_numpy_source_inf
branch
from
22502ee
to
c5eb015
Compare
mzient
approved these changes
Mar 22, 2023
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
|
CI MESSAGE: [7673596]: BUILD STARTED |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def check_pad_last_sample(device): | ||
| @params('cpu', 'gpu') | ||
| def test_pad_last_sample(device): | ||
| def uint8_tensor_to_string(t): |
Check notice
Code scanning / CodeQL
Unused local variable
|
CI MESSAGE: [7673596]: BUILD FAILED |
|
CI MESSAGE: [7673596]: BUILD PASSED |
stiepan
pushed a commit
to stiepan/DALI
that referenced
this pull request
Mar 23, 2023
- fixes missing copy of the source info metadata from samples read in the numpy reader (CPU and GPU) to the operator output Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
samples read in the numpy reader (CPU and GPU) to the
operator output
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
samples read in the numpy reader (CPU and GPU) to the
operator output
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A