Update fix assert error messages in base_iterator.py #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machineko
force-pushed
the
machineko-fix-assert-error-msg
branch
from
305f6e8
to
167101d
Compare
machineko
changed the title
JanuszL
approved these changes
Mar 20, 2023
|
Hi @machineko, Well spotted. Thank you for the fix. |
|
!build |
|
CI MESSAGE: [7646190]: BUILD STARTED |
|
CI MESSAGE: [7646190]: BUILD FAILED |
JanuszL
reviewed
Mar 20, 2023
| @@ -215,7 +215,7 @@ def _extract_from_reader_and_validate(self): | |||
| readers_meta = [p.reader_meta(self._reader_name) for p in self._pipes] | |||
|
|
|||
| def err_msg_gen(err_msg): | |||
| 'Reader Operator should have the same {} in all the pipelines.'.format(err_msg) | |||
| return 'Reader Operator should have the same {} in all the pipelines.'.format(err_msg) | |||
There was a problem hiding this comment.
Can you please check the linter complain?
#14 22.48 Performing Python linter check
#14 25.60 /opt/dali/dali/python/nvidia/dali/plugin/base_iterator.py:218:101: E501 line too long (102 > 100 characters)
#14 25.60 1 E501 line too long (102 > 100 characters)
#14 25.60 1```
There was a problem hiding this comment.
should be fixed right now
|
!build |
Signed-off-by: machineko <machineko@protonmail.com>
Signed-off-by: machineko <machineko@protonmail.com>
machineko
force-pushed
the
machineko-fix-assert-error-msg
branch
from
185e251
to
927516b
Compare
|
CI MESSAGE: [7646361]: BUILD STARTED |
|
CI MESSAGE: [7646361]: BUILD FAILED |
|
CI MESSAGE: [7646361]: BUILD PASSED |
awolant
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
Function without return always return None so error have no information about missing metadata
before
after
Tests:
Documentation