Move the --pending and cv.notify_all() inside the critical section to prevent the notification from going unobserved

[mzient]

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

Previously it could so happen that the order of execution was:

Thread A            Thread B
--pending > 0   
lock(m);
                    --pending == 0
                    cv.notify_all()
cv.wait() <-- hang, ^^^ went unnoticed

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

Imgcodec tests

• Existing tests apply
• New tests added
  • Python tests
  • GTests
  • Benchmark
  • Other
• N/A

Checklist

Documentation

• Existing documentation applies
• Documentation updated
  • Docstring
  • Doxygen
  • RST
  • Jupyter
  • Other
• N/A

DALI team only

Requirements

• Implements new requirements
• Affects existing requirements
• N/A

REQ IDs: N/A

JIRA TASK: N/A

[dali-automaton]

CI MESSAGE: [7647617]: BUILD STARTED

[dali-automaton]

CI MESSAGE: [7647617]: BUILD FAILED

[dali-automaton]

CI MESSAGE: [7647617]: BUILD PASSED