Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds bool type support to PyTorch DALI integration #4757

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Adds bool type support to PyTorch DALI integration #4757

merged 1 commit into from
Mar 31, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 30, 2023

  • adds bool type support to the DALI PyTorch plugin
  • adds tests for PyTorch, MXNet and PaddlePaddle plugins
    to check the supported types

Relates to #4756.

Category:

New feature (non-breaking change which adds functionality)

Description:

  • adds bool type support to the DALI PyTorch plugin
  • adds tests for PyTorch, MXNet and PaddlePaddle plugins
    to check the supported types

Additional information:

Affected modules and functionalities:

  • dali/python/nvidia/dali/plugin/pytorch.py
  • dali/test/python/test_fw_iterators.py

Key points relevant for the review:

  • other types we missed?

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
      • test_fw_iterators:test_pytorch_iterator_feed_ndarray_types
      • test_fw_iterators:test_mxnet_iterator_feed_ndarray_types
      • test_fw_iterators:test_paddle_iterator_feed_ndarray_types
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 30, 2023

!build

@JanuszL JanuszL mentioned this pull request Mar 30, 2023
Closed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7763913]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7763913]: BUILD FAILED

@JanuszL
Adds bool type support to PyTorch DALI integration
07fbcc0 
- adds bool type support to the DALI PyTorch plugin
- adds tests for PyTorch, MXNet and PaddlePaddle
  plugins to check the supported types

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 30, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7765998]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7765998]: BUILD PASSED

@JanuszL JanuszL merged commit 3035218 into NVIDIA:main Mar 31, 2023
@JanuszL JanuszL deleted the add_bool_support_pytorch branch March 31, 2023 15:01
@JanuszL JanuszL mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiepan stiepan stiepan approved these changes

@jantonguirao jantonguirao jantonguirao approved these changes

Assignees

@jantonguirao jantonguirao

@stiepan stiepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JanuszL @dali-automaton @jantonguirao @stiepan