Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning empty pixel mask for COCO samples with no objects #4856

Merged
merged 1 commit into from
May 17, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 15, 2023

  • if the COCO sample doesn't have any object DALI returns
    uninitialized memory instead of an empty pixel mask. This PR fixes that

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • if the COCO sample doesn't have any object DALI returns
    uninitialized memory instead of an empty pixel mask. This PR fixes that

Related to #4855

Additional information:

Affected modules and functionalities:

  • dali/operators/reader/coco_reader_op.cc

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
      • test_coco.test_coco_empty_annotations_pix
      • test_coco.test_coco_empty_annotations_poly
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL
Copy link
Contributor Author

JanuszL commented May 15, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8298764]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8298764]: BUILD FAILED

- if the COCO sample doesn't have any object DALI returns
  uninitialized memory instead of an empty pixel mask.
  This PR fixes that

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented May 15, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8298857]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8298857]: BUILD PASSED

@JanuszL JanuszL merged commit 8f1852b into NVIDIA:main May 17, 2023
@JanuszL JanuszL deleted the fix_empy_coco_seg branch May 17, 2023 16:02
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
…IA#4856)

- if the COCO sample doesn't have any object DALI returns
  uninitialized memory instead of an empty pixel mask.
  This PR fixes that

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants