Make OperatorBase public and move InstantiateOperator to operator.h #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
move_instantiate_operator_function
branch
from
8c66999
to
182d1dd
Compare
|
Build #619025 |
Kh4L
approved these changes
Jan 29, 2019
mzient
reviewed
Jan 29, 2019
dali/pipeline/operators/operator.h
Outdated
| @@ -256,6 +256,9 @@ void CollectPointersForExecution(size_t batch_size, | |||
| const TensorList<GPUBackend> &input, vector<const uint8 *> *inPtrs, | |||
| TensorList<GPUBackend> &output, vector<uint8 *> *outPtrs); | |||
|
|
|||
| using OpPtr = std::unique_ptr<OperatorBase>; | |||
There was a problem hiding this comment.
I wonder if declaring OpPtr here is really a good idea. It's a very short name, that can easily collide with something.
There was a problem hiding this comment.
Agree, I'll remove it
mzient
approved these changes
Jan 29, 2019
JanuszL
approved these changes
Jan 29, 2019
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
move_instantiate_operator_function
branch
from
182d1dd
to
89f7f6d
Compare
|
Build #619046 |
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
…VIDIA#487) Signed-off-by: Joaquin Anton <janton@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com