Disable JAX iterator tests in ASAN build #4920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
|
CI MESSAGE: [8711952]: BUILD STARTED |
jantonguirao
approved these changes
Jun 22, 2023
mzient
approved these changes
Jun 22, 2023
|
CI MESSAGE: [8717952]: BUILD STARTED |
JanuszL
reviewed
Jun 22, 2023
qa/TL0_FW_iterators/test_jax.sh
Outdated
| # it takes very long time to run it with sanitizers on and provides little value so turn it off | ||
| if [ -z "$DALI_ENABLE_SANITIZERS" ]; then | ||
| # General tests for iterators | ||
| ${python_invoke_test} -m '(?:^|[\b_\./-])[Tt]est.*jax*' test_fw_iterators.py |
There was a problem hiding this comment.
I think that works fine, the bellow never happens. I would keep it as a basic test for integration.
JanuszL
reviewed
Jun 22, 2023
qa/TL0_FW_iterators/test_jax.sh
Outdated
Comment on lines
13
to
16
| # it takes very long time to run it with sanitizers on and provides little value so turn it off | ||
| if [ -z "$DALI_ENABLE_SANITIZERS" ]; then | ||
| # General tests for iterators | ||
| ${python_invoke_test} -m '(?:^|[\b_\./-])[Tt]est.*jax*' test_fw_iterators.py |
There was a problem hiding this comment.
Suggested change
| # it takes very long time to run it with sanitizers on and provides little value so turn it off | |
| if [ -z "$DALI_ENABLE_SANITIZERS" ]; then | |
| # General tests for iterators | |
| ${python_invoke_test} -m '(?:^|[\b_\./-])[Tt]est.*jax*' test_fw_iterators.py | |
| # General tests for iterators | |
| ${python_invoke_test} -m '(?:^|[\b_\./-])[Tt]est.*jax*' test_fw_iterators.py | |
| # it takes very long time to run it with sanitizers on and provides little value so turn it off | |
| if [ -z "$DALI_ENABLE_SANITIZERS" ]; then |
|
CI MESSAGE: [8711952]: BUILD FAILED |
|
CI MESSAGE: [8717952]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
JanuszL
approved these changes
Jun 23, 2023
|
!build |
|
CI MESSAGE: [8728335]: BUILD STARTED |
awolant
force-pushed
the
skip_jax_test_in_asan_pipeline
branch
from
d68bcad
to
6fa06eb
Compare
|
CI MESSAGE: [8728335]: BUILD PASSED |
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
* Disable JAX iterator tests in ASAN build Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix
Description:
Running frameworks iterators tests with sanitizers enabled takes a long time, may timeout the job and does not provide that much value.
This PR disables JAX iterator tests when sanitizer is enabled.
Additional information:
Affected modules and functionalities:
JAX iterator tests.
Key points relevant for the review:
Did I run CI pipeline with ASAN?
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A