Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JAX tutorial tests #4944

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Jul 13, 2023

New feature

Category:

Description:

Adds JAX tutorial to Jupyter tests for CI. To make it work some missing parts of model.py were added.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: 3523

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8958758]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8958758]: BUILD FAILED

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8958758]: BUILD PASSED

@awolant awolant merged commit 2459ec1 into NVIDIA:main Jul 13, 2023
4 checks passed
JanuszL pushed a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
* Add JAX tutorial tests, fix and refactor model

Adds JAX tutorial to Jupyter tests for CI. To make it work some missing parts of model.py were added.

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants