Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CV-CUDA build for xavier #4976

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Aug 3, 2023

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • enables CV-CUDA build for Xavier

Additional information:

Affected modules and functionalities:

  • CV-CUDA repo
  • Jetson build configuration

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • test_median_blur
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL marked this pull request as draft August 3, 2023 13:16
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9225783]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9225783]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9227236]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9227236]: BUILD PASSED

@JanuszL JanuszL marked this pull request as ready for review August 3, 2023 18:15
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9236944]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9236945]: BUILD STARTED

@@ -28,4 +28,4 @@
url = https://github.com/cocodataset/cocoapi
[submodule "third_party/cvcuda"]
path = third_party/cvcuda
url = https://github.com/banasraf/CV-CUDA.git
url = https://github.com/JanuszL/CV-CUDA.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of using private CV-CUDA forks we could put a specific branch in the CV-CUDA repo? I'm suggesting this in case anyone of us wouldn't be available to change something in this private fork

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can put branch there. The path would be to use the currently used fork as a base and move to own fork then.

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9236944]: BUILD PASSED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9236945]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9236945]: BUILD PASSED

@JanuszL JanuszL merged commit ed128b4 into NVIDIA:main Aug 5, 2023
3 checks passed
@JanuszL JanuszL deleted the cvcuda_xavier_build branch August 5, 2023 06:51
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants