Fix resizing of volumes larger than 2G. #5306
Conversation
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [12541892]: BUILD STARTED |
|
CI MESSAGE: [12541892]: BUILD PASSED |
mzient
added
the
important-fix
| x = np.stack([np.zeros_like(x), np.zeros_like(x), x], axis=3) | ||
| return x + y + z | ||
|
|
||
| global large_data |
There was a problem hiding this comment.
can't nose2 run tests in parallel?
There was a problem hiding this comment.
@mzient , you could go with class-based suite and "static" setUpClass method to prepare data once in more nose2 compliant way. I think I've done that in debayer tests if you're looking for convienient copy-paste. :)
There was a problem hiding this comment.
@jantonguirao The only danger would be that the caching wouldn't work
@stiepan Perhaps, I've never done that.
There was a problem hiding this comment.
I'd go with the idea that @stiepan suggests
There was a problem hiding this comment.
I'll do it in a follow-up. This is a fix for a hard fault and merging it is more important than code style issues in tests.
|
|
||
|
|
||
| @params((types.INTERP_NN, False), (types.INTERP_LINEAR, False), (types.INTERP_LINEAR, True)) | ||
| def test_large_gpu(interp, antialias): |
There was a problem hiding this comment.
how costly is it? Should we mark it as slow or something?
There was a problem hiding this comment.
Not very. A few seconds.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
If fixes the handling of strides larger than 2G elements.
Additional information:
Affected modules and functionalities:
Resize operator
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A